Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force snippet suggestions to the bottom of completions #609

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

juliasilge
Copy link
Collaborator

Currently, we force snippet suggestions to the bottom of the completions list:

"editor.snippetSuggestions": "bottom",

If we don't force this, then they will go wherever the underlying embeddedCodeCompletionProvider wants them to go. I'll install the new .vsix in VS Code and Positron to show where snippets show up with this proposed change.

@juliasilge
Copy link
Collaborator Author

Before this PR, snippets were always pushed down to the bottom of the completions list. With this new change, the snippets go wherever the underlying completion provider puts them.

For example, in VS Code with vscode-R extension, the snippet for lib is set with the snippetSortOrder of "inline", which means alphabetically with everything else:

Screenshot 2024-11-22 at 3 43 31 PM

In Positron, the R snippets are set to show up with snippetSortOrder of "top":

Screenshot 2024-11-22 at 3 46 27 PM

Quarto probably shouldn't interfere with this ordering.

@juliasilge juliasilge requested a review from cscheid November 25, 2024 22:24
@@ -896,7 +896,6 @@
"strings": "on"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little weirded out by the sheer volume of configuration options that quarto tweaks on its own. Maybe we should consider trimming this down in the future.

I find it quite hard to figure out "who" modified settings like these in the UI. The Settings UI reports "modified elsewhere" but you look in your user / project settings and can't see it being modified so you're left scratching your head about them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the sentiment, but I sort of trust that they were put there for a reason, and am left agreeing with the goal, but unable to come up with a plan to do it that I like.

@juliasilge juliasilge merged commit 772c650 into main Nov 26, 2024
1 check passed
@juliasilge juliasilge deleted the snippet-suggestions-not-at-bottom branch November 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants