aii-dhcp: support optional hostname ip verification #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gombasg
reviewed
Dec 12, 2019
| @@ -20,4 +20,6 @@ type structure_dhcp_dhcp_info = { | |||
| the value you specify in templates. | |||
| } | |||
| "options" ? string{} | |||
| @{Verify hostname in DNS} | |||
| "verifyhostname" ? boolean | |||
There was a problem hiding this comment.
I think this should be choice("yes", "no", "strict") instead of a boolean, where strict would cause the component to fail if gethostbyname() below fails. Usually, not having a hard dependency on DNS being up-to-date is good, but I can think of a few use cases where it would be useful if AII could send the message: You need to wait for DNS to get updated, because otherwise the build will fail later anyway.
There was a problem hiding this comment.
wow, this is long time ago.
sure, but perhaps then choice("yes", "no", "warning") or something. or check_only instead of warning.
There was a problem hiding this comment.
Yeah too long ago really, sorry 😞
My vote is for "warn".
stdweird
force-pushed
the
gombasg-dhcp_plugin
branch
from
9b1fa8c
to
b94cb6d
Compare
stdweird
force-pushed
the
gombasg-dhcp_plugin
branch
from
b94cb6d
to
8d55082
Compare
Add tests, adapted from aii-core. Replace bare open() with CAF::FileReader to make the tests work. Include some improvements which accumulated on our side.
jrha
force-pushed
the
gombasg-dhcp_plugin
branch
from
8d55082
to
8d90658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #296, based on #280