Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for EL9 support #350

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Fixes for EL9 support #350

merged 6 commits into from
Nov 13, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 11, 2024

Fixes problems detected during 24.10.0-rc4

@jouvin jouvin requested a review from jrha November 11, 2024 18:20
@jouvin
Copy link
Contributor Author

jouvin commented Nov 11, 2024

Error in runtest looks weird... I don't think it is related to my changes...

@jrha jrha added this to the 24.10 milestone Nov 11, 2024
@jouvin jouvin mentioned this pull request Nov 12, 2024
Merged
@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

Rerunning the test, it seems one of the modification causes an error in one of the test. I'll investigate.

@jouvin jouvin mentioned this pull request Nov 12, 2024
Merged
@jrha
Copy link
Member

jrha commented Nov 12, 2024

Don't worry too much about lint/indent on lines you haven't touched unless you have lots of spare time!

@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

@jrha trying to fix indentation issues, should not be that long...

@jouvin jouvin force-pushed the aii_el9_fixes branch 4 times, most recently from 2c9cf2e to 46b24e7 Compare November 12, 2024 11:10
@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

@jrha should be ok now, except that the tests are failing in aii-ks that complains that debug should have only one argument... which is no longer true with the implicit call to format(). Not sure where it is coming from...

@jrha
Copy link
Member

jrha commented Nov 12, 2024 •
edited
Loading

Oh, it's using panc 10.2…?

[INFO] --- panc-maven-plugin:10.2:check-syntax (check-generated-pan-syntax) @ ks ---
syntax error [/__w/aii/aii/aii-ks/target/pan/quattor/aii/ks/config.pan:108.18-113.1]

I'll open an PR to update things.

@jrha
Copy link
Member

jrha commented Nov 12, 2024

#353

@jrha
Copy link
Member

jrha commented Nov 12, 2024

Thanks to @wpoely86 for merging all the build tools updates!
You should be able to just rebase this PR now.

@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

Looks good now!

@jrha jrha merged commit 09fc1f2 into quattor:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
backwards incompatible
Milestone
24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jouvin @jrha