ncm-spma: yumng: Major improvements #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- run all operations in one single transaction - use saner repository consistency check and display less criptic message once YUM repos are broken - always refresh YUM metadata - use less verbose and more readable output - warn in case transaction (not) installed/removed expected packages - avoid breaking transaction by protected packages (mainly systemd)
|
Can one of the admins verify this patch? |
|
test this please |
stdweird
reviewed
Oct 31, 2017
ncm-spma/src/main/perl/spma/yumng.pm
Outdated
| @@ -12,17 +12,14 @@ use warnings; | |||
| use NCM::Component; | |||
| our $EC = LC::Exception::Context->new->will_store_all; | |||
| our @ISA = qw(NCM::Component); | |||
| use EDG::WP4::CCM::Path 16.8.0 qw(unescape); | |||
| use EDG::WP4::CCM::Element qw(unescape); | |||
There was a problem hiding this comment.
It would help to describe why ;-)
stdweird
reviewed
Oct 31, 2017
ncm-spma/src/main/perl/spma/yumng.pm
Outdated
| } | ||
| # End here in case of --noaction. | ||
| if ($NoAction) { | ||
| return 1; |
There was a problem hiding this comment.
add a info message of some sort
There was a problem hiding this comment.
The message is already there:
[INFO] Dry run, no changes will be performed (--noaction flag set)
There was a problem hiding this comment.
and:
[INFO] running component: spma
---------------------------------------------------------
[INFO] would mark state of component as needing to run
[INFO] note: running component spma in noaction mode
in the component directly. Assuming we don't need to add this message for the third time in the log.
|
FYI: this code runs in our env for several months en-masse now. It's well tested. Feel free to report any problems should you encounter some. |
|
@jnovy can you also cleanup the description? it still has the template text |
jrha
reviewed
Nov 1, 2017
ncm-spma/src/main/perl/spma/yumng.pm
Outdated
| @@ -180,12 +114,12 @@ sub Configure | |||
|
|
|||
| my $repos = $config->getElement(REPOS_TREE)->getTree(); | |||
| my $t = $config->getElement(CMP_TREE)->getTree(); | |||
|
|
|||
There was a problem hiding this comment.
Can you strip this white-space please.
ncm-spma/src/main/perl/spma/yumng.pm
Outdated
| # Display system info | ||
| if ( defined($t->{quattor_os_release}) ) { | ||
| $self->info("target OS build: ", $t->{quattor_os_release}); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Can you strip this white-space please.
added 2 commits
November 1, 2017 11:26
This change improves resiliency and speed by running all installs and removals in one transation. There were consistency issues in previous version when yumng executed updates in multiple steps. That was causing update to fail despite it could be successfully executed in one step. Full list of changes follow. - run all operations in one single transaction - use saner repository consistency check and display less cryptic message once YUM repos are broken - always refresh YUM metadata - use less verbose and more readable output - warn in case transaction installed/removed unexpected packages - avoid breaking transaction by protected packages (mainly systemd)
jnovy
changed the title
|
Seems automatic tests got stuck at some point? |
|
@hpcugentbot test this please |
jrha
approved these changes
Nov 27, 2017
jrha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less criptic message once YUM repos are broken
expected packages
(mainly systemd)