ncm-spma: apt: Finish implementation #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this is code from a half-finished branch, apologies, please feel free to ignore for now. |
|
@hpcugentbot please test this |
jrha
force-pushed
the
spma-apt
branch
8 times, most recently
from
e43c644
to
b60d7e7
Compare
jrha
force-pushed
the
spma-apt
branch
2 times, most recently
from
74e37a1
to
74d531b
Compare
Provide an internal wrapper for apt commands. Provide a flag to allow errors to become warnings.
Reduce level of more frequently desired debug messages to seperate them from the noise. Don't log entry to Configure.
Reduce debug level of package lists to allow them to be inspected with less noise.
In generate_sources and configure_apt. Handle those undefs.
This could be because they have been renamed (rare) or they are virtual (common) in both cases when run interactively apt will warn the user: e.g. > Note, selecting 'man-db' instead of 'man' However this warning is supressed when the output is not a TTY so we have to contrive another means of identifying these cases.
|
@jrha quickly looking code looks ok. how much is this tested? |
|
Right now I've been using it without issue on an Ubuntu 20.04 VM, but it's definitely early days. |
stdweird
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code is not sufficient to manage apt-based hosts due to major bugs and missing functionality. This PR completes the implementation and can be used to fully manage hosts.