ncm-freeipa: support freeipa 4.7

[stdweird]

Support some minor differences wrt verison 4.7

[jrha]

LGTM, does seem to be failing tests though.

[stdweird]

@jrha any idea how to retrigger the tests? i'll see if i can do this with close/open PR

[jrha]

Looks like ${rpm.release} isn't being expanded when the tests are run:

#   Failed test 'install freeipa component and CLI dependencies in post_reboot'
#   at src/test/perl/aii-basic.t line 61.
#                   '[VERB] AII role aii using predefined principal quattor-aii keytab /etc/quattor-aii.keytab
# [DEBUG] Creating Kerberos instance
# [DEBUG] update_env KRB5_CLIENT_KTNAME = /etc/quattor-aii.keytab.
# [DEBUG] update_env KRB5_KTNAME = /etc/quattor-aii.keytab.
# [DEBUG] Creating FreeIPA::Client instance
# [DEBUG] Login using kerberos
# [DEBUG] Successful login
# [DEBUG] set_api_version using API version v2.230
# [DEBUG] set api_version to 2.230
# [DEBUG] Successful JSON POST
# [DEBUG] api_host_add: successfully add-ed host myhost.example.com
# [DEBUG] Successful JSON POST
# [DEBUG] api_host_mod: successfully mod-ed host myhost.example.com
# # freeipa KS post_reboot
# echo 'begin freeipa post_reboot'
# 
# yum -y install ncm-freeipa-19.12.1-${rpm.release} nss-pam-ldapd ipa-client nss-tools openssl pam_krb5 -c /tmp/aii/yum/yum.conf
# PERL5LIB=/usr/lib/perl perl -MNCM::Component::FreeIPA::CLI -w -e install -- --realm MY.REALM --primary myhost.example.com --domain com --fqdn myhost.example.com --hostcert 1 --otp 'superse\$cret\$OTP'
# 
# echo 'end freeipa post_reboot'
# '
#     doesn't match '(?^m:^yum -y install ncm-freeipa-\d+\.\d+\.\d+-\w+ nss-pam-ldapd ipa-client nss-tools openssl pam_krb5 -c /tmp/aii/yum/yum.conf$)'
# Looks like you failed 1 test of 7.
# INFO: /quattor_test/ncm-freeipa/target/test/cache/aii_2dbasic/profile.1/ccm-active-profile.1-16157.writetest status is mode=420
# INFO: /quattor_test/ncm-freeipa/target/test/cache/aii_2dbasic/profile.1/ccm-active-profile.1-16157 status is mode=420
# INFO: /quattor_test/ncm-freeipa/target/test/cache/aii_2dbasic/latest.cid status is mode=420
# INFO: /quattor_test/ncm-freeipa/target/test/profiles/aii-basic.json status is mode=420
# INFO: /quattor_test/ncm-freeipa/target/test/cache/aii_2dbasic/ccm.cfg status is mode=420
# INFO: /quattor_test/ncm-freeipa/target/test/cache/aii_2dbasic/global.lock status is mode=420
src/test/perl/aii-basic.t ....

[jrha]

So… some more data-points on ${rpm.release} expansion:

✔️ Maven 3.6.3 on EL9 (OS version)
✔️ Maven 3.5.4 on EL8 (OS version)
✔️ Maven 3.8.8 on EL7 (upstream)
✔️ Maven 3.5.2 on EL7 (upstream)
✔️ Maven 3.5.0 on EL7 (upstream)
✔️ Maven 3.3.9 on EL7 (upstream)
✔️ Maven 3.3.1 on EL7 (upstream)
✔️ Maven 3.2.5 on EL7 (upstream)
✔️ Maven 3.1.1 on EL7 (upstream)
✔️ Maven 3.0.5 on EL7 (upstream)
❌ Maven 3.0.5 on EL7 (OS version)

So the OS supplied version is somehow broken.
In any case I'm tempted to say that 3.5.4 should now be our minimum supported version.

[jrha]

Looking at this further, the tests pass fine in a vanilla environment and the remaining issue seems to be caused by something mvn_test.sh is doing.

[stdweird]

@jrha fixed in last commit: reason is https://github.com/quattor/maven-tools/blob/master/build-profile/pom.xml#L119
we probably never noticed this before, eg the rpm version in the target config.pan was very likely faulty as well

[jrha]

Huh! Thanks for the detective work!