Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-metaconfig: kafka broker settings schema for 2.4 #1438

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

itkovian
Copy link
Contributor

@itkovian itkovian commented Apr 7, 2020

Added all the broker settings for kafka 2.4.x.

AFAIK, this is backwards compatible with the previous schema, i.e., only additions.

@stdweird
Copy link
Member

jenkins test this please

1 similar comment
@stdweird
Copy link
Member

jenkins test this please

@ned21 ned21 added this to the 20.3 milestone Jun 12, 2020
Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real issues here, just a couple of questions/suggestions. The one change that would be really good would be to change log.dir to an absolute_file_path type to match the existing log.dirs

ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
@jrha jrha modified the milestones: 20.12, 21.3 Dec 16, 2020
@jrha jrha force-pushed the ncm-metaconfig-kafka-2.3.x branch from 5dba452 to b9c3764 Compare October 7, 2022 14:34
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
ncm-metaconfig/src/main/metaconfig/kafka/pan/schema.pan Outdated Show resolved Hide resolved
@jrha jrha merged commit da3b9ae into quattor:master Jul 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants