ncm-network: fix typos and updated comments #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on holidays, don't wait a feedback from me... |
jrha
reviewed
Aug 7, 2023
aka7
force-pushed
the
ncm_network_enchancements
branch
from
aae1818
to
cc5e45e
Compare
jrha
reviewed
Aug 7, 2023
- fixed typos and updated comments to be more meaningful. - commented out start_openvswitch, support for this will come later.
aka7
force-pushed
the
ncm_network_enchancements
branch
from
cc5e45e
to
165535c
Compare
jrha
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change you are making here, in particular we would like to know:
changes to nmstate.pm to address comments in previous pr.
none