ncm-network: nmstate support for configuring dummy interfaces #1614
Conversation
aka7
force-pushed
the
ncm_network_manage_vips
branch
from
daf451f
to
906d472
Compare
aka7
force-pushed
the
ncm_network_manage_vips
branch
from
906d472
to
84594b3
Compare
support for configuring dummy interfaces using nmstate module. only if manage_vips is set.
aka7
force-pushed
the
ncm_network_manage_vips
branch
from
84594b3
to
7aff660
Compare
| my $ip = $vip->{ip}; | ||
| $ip_list->{ip} = $ip; | ||
| $ip_list->{'prefix-length'} = get_masklen($self, "$ip/$netmask"); | ||
| $dummy_iface{name} = $iface_name; |
There was a problem hiding this comment.
you don't have to write ugly perl code ;)
| $dummy_iface{'profile-name'} = $iface_name; | ||
| $dummy_iface{type} = "dummy"; | ||
| $dummy_iface{state} = "up"; | ||
| $dummy_iface{ipv4}->{enabled} = "true"; |
There was a problem hiding this comment.
if you want a yaml boolean out of this, use the yaml constant for true. what does this geneate? the string true incl quotes, that evaluates to true by accident?
| my $netmask = $vip->{netmask} || "255.255.255.255"; | ||
| my $ip = $vip->{ip}; | ||
| $ip_list->{ip} = $ip; | ||
| $ip_list->{'prefix-length'} = get_masklen($self, "$ip/$netmask"); |
| $dummy_iface{state} = "up"; | ||
| $dummy_iface{ipv4}->{enabled} = "true"; | ||
| $dummy_iface{ipv4}->{address} = [$ip_list]; | ||
| my $iface_cfg->{'interfaces'} = [\%dummy_iface]; |
There was a problem hiding this comment.
the single quotes are not needed when the key is unambigious, so here is. (profile-name isn't, perl thinks you are subtracting 2 function calls in that case)
so you can do
my $iface_cfg->{interfaces} = [{
'profile-name' => $iface_name,
type -> "dummy",
state => "up",
ipv4 => {
enabled => $YTRUE,
address => [$iplist],
},
}]
There was a problem hiding this comment.
@aka7 can you fix this in some other PR?
There was a problem hiding this comment.
yes, will go through all your comments and will do a new pr to fix all that. np.
Thanks for you review @stdweird appreciate it.
| my $vips = $net->{vips}; | ||
| my $idx = 0; | ||
| foreach my $name (sort keys %$vips) { | ||
| my $dummy_name="dummy$idx"; |
There was a problem hiding this comment.
spaces around =
but euhm, all dummy vip names might changes by adding a single interface with name that is earlier in alphabetic order? (i have no easy fix besides chagin the schema to a list, but just be aware of this "feature")
providing support for configuring dummy interfaces using nmstate module.
Why the change is necessary.
internally we use frr to configure vips and routing, ffr configuration are using pan, this change is to allow ncm-network to create the loopback interface for the vips defined. I don't see anything upstream about creating this type of interface, so schema change should not impact anything in network.pm.
What backwards incompatibility it may introduce.
none, change is to nmstate.pm which shouldn't impact current network module.