ncm-network: provide a better way to cleanup inactive connections #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka7
force-pushed
the
ncm_network_fix
branch
2 times, most recently
from
64d1f50
to
9976af0
Compare
ned21
reviewed
Dec 9, 2023
New approach to cleaning up inactive connections to have clean output after the run. This also fixes an issue where active connnections named 'Wired connection ethX' are deleted before network changes are applied. This is means in some edge cases if first ncm-network run fails then you have no networking. Therefore no need to delete any auto connections created by NetworkManager, instead we just cleanup connections which are inactive at the end. Wired connection ethX is created by NM automatically, to stop this one can install NetworkManage-config-server package, which stops NM creating such auto connections automaticailly. provide option to turned this off.
aka7
force-pushed
the
ncm_network_fix
branch
from
9976af0
to
6f5e7f0
Compare
|
Thanks for the improvement. LGTM but I will leave someone outside of MS to do the actual approval. |
jrha
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New approach to cleaning up inactive connections so have clean output after the run.
This also fixes an issue where active connnections named 'Wired connection ethX' are deleted before network changes are applied. This is means in some edge cases if first ncm-network run fails then you have no networking. Therefore no need to delete any auto connections created by NetworkManager, instead we just cleanup connections which are inactive at the end.
Wired connection ethX is created by NM automatically, to stop this one can install NetworkManage-config-server package, which stops NM creating such auto connections automaticailly.
provide option to turned this off.
Why the change is necessary.
to cleanup connections which have been made inactive after ncm run is completed with nmstate.
What backwards incompatibility it may introduce.
None, this change is to nmstate backend.