ncm-network: nmstate - down the interface connection before applying #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned21
reviewed
Jan 2, 2024
nmstatectl apply does not replace running config instead it seems to append. This is not useful when settings have been removed such as policy routing. Therefore down the interface connection during configuration changes. This will be now similar to original main ncm network module where it runs ifdown and ifup during config changes.
aka7
force-pushed
the
ncm_network_nmstate_ifdown
branch
from
834c8da
to
0b9945d
Compare
|
closing PR in favor of one, #1647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take down the connection using nmcli before applying changes.
nmstatectl apply does not replace running config instead it seems to append. This is not useful when settings have been removed such as policy routing. Therefore down the interface connection during configuration changes. This will be now similar to original main ncm network module where it runs ifdown and ifup during config changes.
#1643
Why the change is necessary.
Get correct configs applied after a change to profile
What backwards incompatibility it may introduce.
None