ncm-network: nmstate dgw fix #1656
Merged
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aka7 thanks for the quick work. I can confirm this code now does to default gateways what I would expect! |
aka7
force-pushed
the
nmstate_dgw_fix
branch
2 times, most recently
from
da1e033
to
a22b5f1
Compare
thanks for confirming, I've opened this PR for review now. I think this will be better then what I had before as I assumed every interface will have gateway defined. Also bear in mind, nmstate module does not provide all functionalities currently provided by network.pm, as many of comments in the nmstate.pm states. @wdpypere |
stdweird
reviewed
Mar 17, 2024
stdweird
reviewed
Mar 17, 2024
|
@aka7 can you also have a look at this? |
aka7
force-pushed
the
nmstate_dgw_fix
branch
2 times, most recently
from
db9dc61
to
bf69457
Compare
nmstate requires next-hop-interface for every route to be added. Create default route entry only on the interface if default_gateway falls within subnet boundary. fixes quattor#1655
stdweird
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for setting default gateway in nmstate with correct interface by looking up if gateway falls within subnet boundary.
next-hop-interface is mandatory for nmstate therefore figure out which interface subnet this gateway falls in.
This will provide backward compatibility with network.pm
closes #1655
Why the change is necessary.
to provide backward compatibility with network.pm when setting default gateway. without having to set gateway address on interface.
What backwards incompatibility it may introduce.
None.