ncm-network: provide backward compatibility for vlan interface config for nmstate. #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned21
reviewed
Mar 5, 2024
aka7
force-pushed
the
ncm_network_nmstate_vlan
branch
2 times, most recently
from
3c4dd21
to
73e3e22
Compare
stdweird
reviewed
Mar 17, 2024
… for nmstate improvement made to nmstate to provide backward compatibility with network.pm for configuring vlan interface.
aka7
force-pushed
the
ncm_network_nmstate_vlan
branch
from
73e3e22
to
fbad4e0
Compare
stdweird
reviewed
Mar 18, 2024
stdweird
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvements to nmstate to provide backward compatibility with network.pm for configuring vlan interface.
At morganstanley, we use path
closes #1660
..etc
nmstate was development with that in mind,
This change will now provide backward compatibility support with network.pm, so following config will also work.
Why the change is necessary.
provide backward compatibility with network.pm for configuration vlan interface.
What backwards incompatibility it may introduce.
None.