ncm-metaconfig: Allow basic httpd remoteip config to be expressed #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See https://httpd.apache.org/docs/2.4/mod/mod_remoteip.html - Added to the global section because, even though `remoteipproxyprotocol` can be defined at the vhost level, only one such definition will take affect, and do so globally.
|
I'm not sure why runtests - it seems to error on |
jrha
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the change is necessary.
RemoteIPProxyProtocolcan be defined at the vhost level, only one such definition will take affect, and do so globally.What backwards incompatibility it may introduce.
None, the new features have been added as optional.