Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-sysctl: Cleanup & fixes #1710

Merged
merged 3 commits into from
Sep 17, 2024
+1 −6
Merged

ncm-sysctl: Cleanup & fixes #1710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
335cfd9
ncm-sysctl: Trim newlines at EOF
jrha Jul 12, 2024
9cb8ddb
ncm-sysctl: Remove shebang and editor config from tests
jrha Jul 12, 2024
04c2abb
ncm-sysctl: Deprecate compat-v1 as having no effect
jrha Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ncm-sysctl/src/main/pan/components/sysctl/schema.pan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type component_sysctl_structure = {
include structure_component

'command' : string = '/sbin/sysctl' with match(SELF, '^/.+')
'compat-v1' : boolean = false
'compat-v1' ? boolean with deprecated(0, 'compat-v1 has no effect and will be removed in a future release')
'confFile' : string = '/etc/sysctl.conf' with match(SELF, '^(/.+|[^/]+)\.conf$') # disallow / unless an absolute path is supplied.
'variables' ? string{}
};
Expand Down
2 changes: 0 additions & 2 deletions ncm-sysctl/src/test/perl/configure.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/usr/bin/perl
# -*- mode: cperl -*-
use strict;
use warnings;

Expand Down
3 changes: 0 additions & 3 deletions ncm-sysctl/src/test/resources/simple.pan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,3 @@ prefix "/software/components/sysctl";
"command" = "/sbin/sysctl";
"confFile" = "50-quattor.conf";
"variables/kernel.sysrq" = "1";