ncm-ntpd: introduce useserverip boolean to force hostname to IP #558
Conversation
|
@jrha this looked easy, so i fixed it. could be pushed to 15.8 if wanted |
|
Refer to this link for build results (access rights to CI server needed): |
|
What's with the merge commit? |
|
@jrha is that from pushing the 'update branch' button? |
|
I think so, I've never seen that button... |
|
so we shouldn't press that button? i just asked some people to do so in their PRs |
|
I hate merge commits. Also: merging from master into topic is just wrong. |
|
@jrha so pressing the update branch button is a big no-no adn we should only rebase? |
|
I would prefer that, yes. |
stdweird
force-pushed
the
ntpd_server_names
branch
from
161fefb
to
8043e1a
Compare
|
cleaned up |
| prefix '/software/components/${project.artifactId}'; | ||
| 'active' ?= true; | ||
| 'dispatch' ?= true; | ||
| 'version' ?= '${no-snapshot-version}'; |
There was a problem hiding this comment.
What's the purpose of this attribute? I thought it was to trigger a re-run of the component after the version changed but I recently discovered that ncm-cdispd watches /software/packages/ncm-$component and re-runs any components that has been upgraded. Is this still useful or should be it be dropped?
There was a problem hiding this comment.
it will become useful with quattor/ncm-ncd#41
we can remove all version attributes now, and readd them later
There was a problem hiding this comment.
If we have a use for them then leave them in. Just trying to make sure we have a consistent view of what is required in this files!
…ss translation in the config files(s)
stdweird
force-pushed
the
ntpd_server_names
branch
from
8043e1a
to
750cf4b
Compare
ncm-ntpd: introduce useserverip boolean to force hostname to IP
The component will always try to resolve the configured timeservers, but uses the configured hostname instead of the resolved IP address. If one really wants the resolved IP address rather then the hostname, a new boolean
useserveripis introduced to force this behaviour.Fixes #531