Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CCM::TextRender instead of CAF::TextRender in RegexpTest #53

Merged
merged 7 commits into from
May 5, 2015

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented May 2, 2015

Use CCM::TextRender instead of CAF::TextRender in RegexpTest; the unittests now can also test with element instances.

Some other minor related modifications

  • a convenience method set_json_typed to enable json_typed (together with a get_json_typed to check the current setting)
  • an advanced option to overrride the module and contentspath via regexptest flags (useful to test rendering of the /-element); but this should considered an exception.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/maven-tools-pr-builder/45/
Test FAILed.

@stdweird
Copy link
Member Author

stdweird commented May 2, 2015

@jrha this needs quattor/CCM#51 to pass the tests, is based on #52 and is a requirement for quattor/configuration-modules-core#475

i'm also tagging this 15.4

@stdweird stdweird added this to the 15.4 milestone May 2, 2015
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/maven-tools-pr-builder/46/
Test FAILed.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/maven-tools-pr-builder/47/
Test FAILed.

@stdweird
Copy link
Member Author

stdweird commented May 3, 2015

test this please

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/maven-tools-pr-builder/48/
Test PASSed.

@jouvin
Copy link
Contributor

jouvin commented May 4, 2015

@stdweird I have the feeling that some of the commits are related to JSON type support not really to CCM:TextRender. Am I right? In this case, it would be good to adjust the title of the PR...

Also, it would be good to have a short description of the goal of the PR... Not really obvious without an explanation! (I have no doubt it is useful)

Else LGTM.

@stdweird
Copy link
Member Author

stdweird commented May 5, 2015

@jouvin i updated the PR description. i'm afraid that it will only become really clear why this is relevant when i update quattor/CAF#84 with the CCM::TextRender features that are part of 15.4

the json_typed fixes are relevant for any testing which requires typed data, which requires CCM::TextRender.

jrha added a commit that referenced this pull request May 5, 2015
Use CCM::TextRender instead of CAF::TextRender in RegexpTest
@jrha jrha merged commit 538750d into quattor:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants