ComponentProxy: report differences between profile and package version #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Apply version related checks. | ||
|
|
||
| Return C<SUCCESS> if there are no version-related issues; | ||
| report an error and return undef otherwsie. |
There was a problem hiding this comment.
I see "version-related issues" is deliberately kept undefined, I guess pending resolution of the discussion in #41? So the doc is accurate, but potentially a little confusing ?
There was a problem hiding this comment.
yes, i put that in the comment below. but i could add it here, eg. Current version only reports possible different versions, and always returns C<SUCCESS> (but behaviour might change in future version)
stdweird
force-pushed
the
cleanup_proxy
branch
from
5b61fa6
to
ac3be1e
Compare
stdweird
force-pushed
the
cleanup_proxy
branch
from
ac3be1e
to
887ab9e
Compare
|
@jrha fixed typo |
|
LGAFAICT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48