Skip to content

Commit

Permalink
coding_style: Document each's evilness
Browse files Browse the repository at this point in the history
  • Loading branch information
jrha committed Sep 12, 2024
1 parent bca55fd commit 474589c
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions _development/coding_style.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,29 @@ And the bad example:
my $circle_area = $radius ** 2 * 3.14159;
```

### Don't use each

`each` is evil, and although it can be used correctly, should be avoided. The problem is that each sort-of remembers the last element it iterated over, this has all sorts of nasty side effects.

Use `foreach` to iterate over `keys` instead.

Bad example:

```perl
while (my ($k, $v) = each(%h)) {
...
}
```

Good example:

```perl
foreach my $k (keys %h) {
my $v = $h{$k};
...
}
```

### Module header

A Perl module **must** start with a line like:
Expand Down

0 comments on commit 474589c

Please sign in to comment.