Ensure max_threads is set for all CPUs defined under /hardware/cpu/ #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not fix |
|
In addition to templates changes? Or keeping old templates as they are? I can make it default to cores count when needed, but some people might end up having less thread count by default.. which is not too bad but probably not optimal 🤷♂️ |
|
Yep, in addition to this change (which is fine in itself), but the schema doesn't enforce the property being present, so |
jrha
approved these changes
Aug 23, 2024
jrha
force-pushed
the
ma_add_max_threads_to_cpu_definitions
branch
from
268d4f4
to
ff9ee65
Compare
This was needed to avoid hitting a bug when using the get_num_of_max_threads() function. This assumes that hyperthreading is enabled. For CPUs that do not support hyperthreading it sets max_threads to the value of cores count.
|
Rebased. |
This was referenced Sep 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed to avoid hitting a bug when using the get_num_of_max_threads() function.
This assumes that hyperthreading is enabled.
For CPUs that do not support hyperthreading it sets max_threads to the value of cores count.