Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MD5 hash construction to avoid false-positives #140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change MD5 hash construction to avoid false-positives #140

wants to merge 3 commits into from

Commits on Aug 1, 2021

  1. Change MD5 hash construction to avoid false-positives 

    Update to quentinsf#100,
see quentinsf#134.

Note that this will cause current transactions to become unique.
Appropriate adjustments have been made to existing tests.
    Antlers committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    6a873da View commit details
    Browse the repository at this point in the history

  2. Add '--depreciated-md5' to allow skipping old hashes 

    * Added it to `README.md`, made sure it looks alright in the `--help`
docs.

* Includes a new test for '--depreciated-md5', with a new transaction
in transfer.csv.

* Added a small informational header to parsed_transfer.txt, which
already wasn't the literal (ie. untouched) result of parsing
transfer.csv because of the removal of the last transaction.

* I think a great alternative would be a seperate script that updates
the hashes in a given file (given the appropriate source account)
based on either the inline CSV record or the input file that was used.

  * An implimentation of the `Inline CSV + Source Account` method must
  check that the existing hash actually matches an old approach to
  hashes before updating it!
    Antlers committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    7b5f5c5 View commit details
    Browse the repository at this point in the history

  3. Remove redundant (duplicated) transaction from testing stub 

    It doesn't look like this is used for anything, and the tests don't
fail without it, but correct me if I'm wrong ofc
    Antlers committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    b306dac View commit details
    Browse the repository at this point in the history