Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the table name from the query structure. #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Apr 21, 2021

This PR is based on experimenting with SMUI with sqlserver and mysql databases. SQLServer specifically didn't like the table name being part of the column names. With this PR (and some tweaks to the schema) SMUI could run against SQLServer.

I thought more about it, and thought that not having the table name in the rowparser would make it easier to read.

I don't know if there are any other simplifications that could be made?

@pbartusch
Copy link
Collaborator

Thanks , @epugh for the PR.
It needs to be checked , if removing the table prefixes will break the test automation (hint: some JOINs are used in the EventHistory feature).

I understand , removing the table prefixes is necessary in order to have a broader DBMS support like suggested in #69 .

@epugh
Copy link
Contributor Author

epugh commented May 14, 2021

BTW, I did run these tests:

➜  smui-o19s git:(simplify_sql_query_structure) ./runE2ETests.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants