Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the mint default cookie protector to generate cookies #978

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

marten-seemann
Copy link
Member

Fixes #966. Should be merged after bifurcation/mint#141 gets merged.

@marten-seemann marten-seemann changed the title use the mint default cookie source to generate cookies use the mint default cookie protector to generate cookies Dec 6, 2017
@marten-seemann
Copy link
Member Author

@lucas-clemente: We renamed mint.CookieSource to mint.CookieProtector before bifurcation/mint#141 was merged. I made the necessary changes to this PR, and also renamed our variables from source to protector.

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #978 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   90.71%   90.85%   +0.14%     
==========================================
  Files          99       98       -1     
  Lines        6543     6513      -30     
==========================================
- Hits         5935     5917      -18     
+ Misses        391      385       -6     
+ Partials      217      211       -6
Impacted Files Coverage Δ
internal/handshake/cookie_generator.go 90.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851b44c...7ba613c. Read the comment docs.

@raininja
Copy link

raininja commented Dec 4, 2018

I'm running into an issue with this code in caddy. Trying to build caddy results in this error:

# github.com/mholt/caddy/vendor/github.com/lucas-clemente/quic-go/internal/handshake
vendor/github.com/lucas-clemente/quic-go/internal/handshake/cookie_generator.go:32:18: undefined: mint.CookieProtector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants