Exit on sanitizer trap, don't recover

Fixes: #22
quickjs-ng · Nov 8, 2023 · 558a2ac · 558a2ac
1 parent 8956d6b
commit 558a2ac
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -33,21 +33,21 @@ jobs:
       - uses: actions/checkout@v3
       - name: test
         run: |
-          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_ASAN=y test
+          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_ASAN=y ASAN_OPTIONS="halt_on_error=1" test
   linux-msan:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - name: test
         run: |
-          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_MSAN=y CONFIG_CLANG=y test
+          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_MSAN=y CONFIG_CLANG=y MSAN_OPTIONS="halt_on_error=1" test
   linux-ubsan:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - name: test
         run: |
-          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_UBSAN=y test
+          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_UBSAN=y UBSAN_OPTIONS="halt_on_error=1" test
 
   macos:
     runs-on: macos-latest
@@ -69,14 +69,14 @@ jobs:
       - uses: actions/checkout@v3
       - name: test
         run: |
-          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_ASAN=y test
+          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_ASAN=y ASAN_OPTIONS="halt_on_error=1" test
   macos-ubsan:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v3
       - name: test
         run: |
-          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_UBSAN=y test
+          make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y CONFIG_UBSAN=y UBSAN_OPTIONS="halt_on_error=1" test
 
   windows-mingw:
     runs-on: windows-latest

diff --git a/Makefile b/Makefile
@@ -141,16 +141,16 @@ CFLAGS+=-p
 LDFLAGS+=-p
 endif
 ifdef CONFIG_ASAN
-CFLAGS+=-fsanitize=address -fno-omit-frame-pointer
-LDFLAGS+=-fsanitize=address -fno-omit-frame-pointer
+CFLAGS+=-fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer
+LDFLAGS+=-fsanitize=address -fno-sanitize-recover=all -fno-omit-frame-pointer
 endif
 ifdef CONFIG_MSAN
-CFLAGS+=-fsanitize=memory -fno-omit-frame-pointer
-LDFLAGS+=-fsanitize=memory -fno-omit-frame-pointer
+CFLAGS+=-fsanitize=memory -fno-sanitize-recover=all -fno-omit-frame-pointer
+LDFLAGS+=-fsanitize=memory -fno-sanitize-recover=all -fno-omit-frame-pointer
 endif
 ifdef CONFIG_UBSAN
-CFLAGS+=-fsanitize=undefined -fno-omit-frame-pointer
-LDFLAGS+=-fsanitize=undefined -fno-omit-frame-pointer
+CFLAGS+=-fsanitize=undefined -fno-sanitize-recover=all -fno-omit-frame-pointer
+LDFLAGS+=-fsanitize=undefined -fno-sanitize-recover=all -fno-omit-frame-pointer
 endif
 ifdef CONFIG_WIN32
 LDEXPORT=