Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared library target to CMake #60

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Add shared library target to CMake #60

merged 2 commits into from
Nov 14, 2023

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 14, 2023

No description provided.

@saghul saghul force-pushed the cmake-shared branch 2 times, most recently from 6ac6a2c to d4d08fa Compare November 14, 2023 13:09
bnoordhuis
bnoordhuis reviewed Nov 14, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@saghul
Copy link
Contributor Author

saghul commented Nov 14, 2023

Updated!

bnoordhuis
bnoordhuis approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@bnoordhuis
Copy link
Contributor

...but needs a s/qjs-shared/qjs/g :)

@saghul saghul merged commit 0b09109 into master Nov 14, 2023
16 checks passed
@saghul saghul deleted the cmake-shared branch November 14, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis