Add test for illegal literal parameter #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,7 @@ def capybara(x: X, y: Y) -> None: | |||
| def test_literal(self): | |||
| from typing_extensions import Literal | |||
|
|
|||
| def capybara(x: Literal[True], y: Literal[True, False]) -> None: | |||
| def capybara(x: Literal[True], y: Literal[(True, False)]) -> None: | |||
There was a problem hiding this comment.
I don't think pyanalyze will catch this as the AST is the same either way. Mypy accepts this too.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for checking then I think I can close this, and open an issue in Python repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to typing spec tuple value inside a Literal type annotation is not allowed.