[SVGThumbnails]Fix hanging loop and add logs (microsoft#31116)

quyenvsp · Jan 24, 2024 · 6f5a59b · 6f5a59b
1 parent 172db3a
commit 6f5a59b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/modules/previewpane/SvgThumbnailProvider/Program.cs b/src/modules/previewpane/SvgThumbnailProvider/Program.cs
@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Globalization;
+using ManagedCommon;
 
 namespace Microsoft.PowerToys.ThumbnailHandler.Svg
 {
@@ -17,6 +18,7 @@ internal static class Program
  public static void Main(string[] args)
  {
  ApplicationConfiguration.Initialize();
+ Logger.InitializeLogger("\\FileExplorer_localLow\\SvgThumbnails\\logs", true);
  if (args != null)
  {
  if (args.Length == 2)

diff --git a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.cs
@@ -7,6 +7,7 @@
 using System.Runtime.CompilerServices;
 using System.Threading;
 using Common.Utilities;
+using ManagedCommon;
 using Microsoft.Web.WebView2.Core;
 using Microsoft.Web.WebView2.WinForms;
 
@@ -197,8 +198,10 @@ public Bitmap GetThumbnailImpl(uint cx)
  _browser.NavigateToString(SvgContents);
  }
  }
- catch (Exception)
+ catch (Exception ex)
  {
+ Logger.LogError($"Failed running webView2Environment completed for {FilePath} : ", ex);
+ thumbnailDone.Set();
  }
  });
 

diff --git a/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.csproj b/src/modules/previewpane/SvgThumbnailProvider/SvgThumbnailProvider.csproj
@@ -52,5 +52,6 @@
  <ProjectReference Include="..\..\..\common\GPOWrapper\GPOWrapper.vcxproj" />
  <ProjectReference Include="..\..\..\common\ManagedTelemetry\Telemetry\ManagedTelemetry.csproj" />
  <ProjectReference Include="..\Common\PreviewHandlerCommon.csproj" />
+ <ProjectReference Include="..\..\..\common\Common.UI\Common.UI.csproj" />
  </ItemGroup>
 </Project>