Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netezza / custom odbcDataType #847

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Netezza / custom odbcDataType #847

merged 4 commits into from
Sep 12, 2024

Conversation

detule
Copy link
Collaborator

@detule detule commented Sep 10, 2024 •
edited
Loading

Hello:

This closes #841

  • At some point I will investigate if there are any back ends that don't support the VARCHAR(n) syntax. At that point we can maybe make this part of the generic method.
  • At any rate, have seen a few Netezza issues come up; declaring a new class seems appropriate.

To do before merging:

  • Add NEWS item.

simonpcouch
simonpcouch approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a Netezza instance to test against either, but I'm convinced! Agreed that a new class is in scope. Looks clean!

@detule detule merged commit 5a858ba into r-dbi:main Sep 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbDataType chooses VARCHAR(255) even when nchar > 255
2 participants
@detule @simonpcouch