Merge pull request #817 from olivroy/popup-message

Improve popup.vars error message
r-tmap · Jan 11, 2024 · 9863372 · 9863372
2 parents 1da6343 + fce9cc9
commit 9863372
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/R/step1_helper_facets.R b/R/step1_helper_facets.R
@@ -169,8 +169,7 @@ step1_rearrange_facets = function(tmo, o) {
 				popup.format = process_label_format(popup.format, o$label.format)
 
 				if (!all(popup.vars %in% smeta$vars)) {
-					# TODO add a more informative message that says which variables are incorrect.
-					stop("Incorrrect popup.vars specification", call. = FALSE)
+					rlang::arg_match(popup.vars, values = smeta$vars, multiple = TRUE)
 				}
 				if (length(popup.vars)) add_used_vars(popup.vars)