CI progress #779
Merged
CI progress #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to merge, as 4/5 CI is passing! It is an improvement. There is always https://vdiffr.r-lib.org/ to test the looks of visualizations, not yet implemented and interactive maps could be tested via articles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some testing within testthat framework.
There was only one last failing example that was holding up this part of r cmd check.
Adding tests to testthat ensures that when there is a failing test, that others are run, so it gives a more general overview of what is working and what is not. I would understand if you don't want to pursue that route. It doesn't have to be perfect now.
Addresses #776
they can always be deleted later.