Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check + move build to data-raw #782

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Sep 20, 2023

Since some data doesn't exist anymore, I was not able to rebuild data from scratch yet, as it may require more time, but here is a PR that moves them to the data-raw folder and renames files so that they correspond to the database.

I also used devtools::spell_check(). Since color is used more over colour, I assumed the package uses American English, which implies grey -> gray. behaviour -> behavior etc.

This should be my last large-scope PR. But please review carefully ! thanks

Copy link
Contributor Author

@olivroy olivroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some precisions on what I did

data-raw/tmap.pal.info.R Show resolved Hide resolved
vignettes/tmap_sneak_peek.Rmd Show resolved Hide resolved
vignettes/tmap_sneak_peek.Rmd Show resolved Hide resolved
README.md Show resolved Hide resolved
R/tmap_options.R Show resolved Hide resolved
@olivroy olivroy mentioned this pull request Sep 20, 2023
5 tasks
@mtennekes mtennekes merged commit e2eaf4c into r-tmap:master Sep 20, 2023
4 of 5 checks passed
@olivroy olivroy deleted the data-raw branch September 20, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants