Lints + add tests + fix R CMD CHECK #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowosad
reviewed
Oct 22, 2023
| @@ -23,3 +23,12 @@ utils::globalVariables(c( | |||
| "t2", "t3", "t4", "text.fontface", "text.fontfamily", "title.bg.alpha", | |||
| "tmapID__", "vneutral" | |||
| )) | |||
|
|
|||
| # Add more to silence R CMD CHECK (see if some are false positive) | |||
| utils::globalVariables(c( | |||
There was a problem hiding this comment.
It was flagged by R CMD CHECK in step1_helper_facets.R
value = tmapVars(getAesOption("value.blank", o, aes = aes, layer = layer))
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests for the latest issues that were solved.
FIx some R CMD CHECK warnings
Use latest testthat for snapshots.
Use isFALSE() over identical(x, FALSE)`.
Skip test that is failing. (many titles still do not work)