Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address notes #846

Merged
merged 4 commits into from
Mar 17, 2024
Merged

address notes #846

merged 4 commits into from
Mar 17, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Mar 15, 2024 •
edited
Loading

Even though it doesn't make sense, I added a method to avoid ugly failure with view mode.
Example in #842

tm_shape(World) + 
     tm_polygons ("HPI", 
                  fill.scale = tm_scale_intervals(), 
                  fill.chart = tm_chart_donut())
#> charts not implemented in view mode
#> Erreur dans UseMethod("tmapLeafletLegPlot") : 
#>  pas de méthode pour 'tmapLeafletLegPlot' applicable pour un objet de classe "c('tm_chart_donut', 'tm_chart', #> 'tm_component', 'list')"

@olivroy olivroy marked this pull request as ready for review March 15, 2024 13:36
@mtennekes mtennekes merged commit 9e76b33 into r-tmap:master Mar 17, 2024
7 checks passed
@olivroy olivroy deleted the checks branch March 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivroy @mtennekes