Fix partial matching + silence R cmd check notes + warnings #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `popup.vars` in #817
…to avoid partial matching warnings.
olivroy
changed the title
|
Thx! I think/believe it's correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not fix CI, but gets some of it out of the way.
Fix typos (hope they won't create conflicts on your local branch) feel free to push your local changes if you have some and I can fix the conflicts on the PR.
Note the change in d3bfa69 to address partial match warnings. Let me know if you think it is correct.
Thanks
I also changed a warning into a message and adjusted warnings for
idandlabel. I think that all deprecation of v3 should be messages for now as CRAN will force a new CRAN release to revdep packages.