Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export opt_tm_markers() #859

Merged
merged 5 commits into from
Apr 10, 2024
Merged

export opt_tm_markers() #859

merged 5 commits into from
Apr 10, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Apr 9, 2024

Required to have examples passing!

Commenting out for now the only remaining one that doesn't work.

data("NLD_prov")
NLD_prov$x = seq(10, by = 5, length.out = 12)

tm_shape(NLD_prov) + 
	tm_symbols(size = "x", size.scale = tm_scale_continuous(values.scale = 4)) +
	tm_text(text = "x")

All other examples (except dontrun work currently!)

@olivroy olivroy mentioned this pull request Apr 9, 2024
examples/tm_symbols.R Outdated Show resolved Hide resolved
@olivroy olivroy mentioned this pull request Apr 9, 2024
@mtennekes
Copy link
Member

#860 is fixed: is this still needed?

@olivroy
Copy link
Contributor Author

olivroy commented Apr 9, 2024

Yes, I reverted unnecessary changes, but you can squash merge this (or commit the remaining changes to master yourself) to avoid ugly history. https://github.com/r-tmap/tmap/pull/859/files

  • export opt_tm_markers + remove unneeded line

@mtennekes mtennekes merged commit 456a300 into r-tmap:master Apr 10, 2024
@olivroy olivroy deleted the example branch April 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants