Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evaluating.qmd #228

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Update evaluating.qmd #228

merged 2 commits into from
Jul 21, 2023

Conversation

bahadzie
Copy link
Contributor

Minor correction.

Copy link
Member

@georgestagg georgestagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the delay in review! I have a minor question about one of the two changes but otherwise happy to approve.

@@ -23,7 +23,7 @@ The normal stream output is written to the JavaScript console. The error stream

### Returning JavaScript values when evaluating R code

A selection of convenience methods return the result of evaluating R code as a promise resolving to a JavaScript object, rather than an `RObject` reference. The benefit is that since the returned object is of a raw JavaScript type, it does not need to be memory managed like an `RObject` result would be.
A selection of convenience methods return the result of evaluating R code as a promise to a JavaScript object, rather than an `RObject` reference. The benefit is that since the returned object is of a raw JavaScript type, it does not need to be memory managed like an `RObject` result would be.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is removing the word "resolving" here deliberate? It's not duplicated in this instance.

@georgestagg georgestagg merged commit 2a8b215 into r-wasm:main Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants