Change implementation of auto start to be stable

Auto starting the service in MyTileService.kt onCreate() was a problem
that led to unpredictable behaviors of the service starting itself
when not plugged in.

Auto starting the service in the MainActivity.kt onCreate() also led
to the similar issues from above.

app/build.gradle

@@ -24,8 +24,8 @@ android {
     applicationId "com.r3bl.stayawake"
     minSdkVersion 25
     targetSdkVersion 28
-    versionCode 15
-    versionName "2.3"
+    versionCode 16
+    versionName "2.4"
   }
   buildTypes {
     release {

app/src/main/java/com/r3bl/stayawake/MainActivity.kt

@@ -79,7 +79,7 @@ class MainActivity : AppCompatActivity() {
     loadAndApplyFonts()
     formatMessages()
 
-    handleAutoStartOfService()
+    //handleAutoStartOfService()
 
     setupCheckbox()
     setupSpinner(typeNotoSansRegular)
@@ -95,13 +95,13 @@ class MainActivity : AppCompatActivity() {
     super.onStop()
   }
 
-  private fun handleAutoStartOfService() {
-    if (mySettingsHolder.value.autoStartEnabled && MyTileService.isCharging(this)) {
-      MyTileService.fireIntentWithStartService(this)
-      d(TAG, "MainActivity.handleAutoStartOfService: Initiate auto start")
-    }
-    else d(TAG, "MainActivity.handleAutoStartOfService: Do not auto start")
-  }
+//  private fun handleAutoStartOfService() {
+//    if (mySettingsHolder.value.autoStartEnabled && MyTileService.isCharging(this)) {
+//      MyTileService.fireIntentWithStartService(this)
+//      d(TAG, "MainActivity.handleAutoStartOfService: Initiate auto start")
+//    }
+//    else d(TAG, "MainActivity.handleAutoStartOfService: Do not auto start")
+//  }
 
   private fun setupCheckbox() = mySettingsHolder.value.autoStartEnabled.let { autoStartEnabled ->
     checkbox_prefs_auto_start.isChecked = autoStartEnabled

app/src/main/java/com/r3bl/stayawake/MyTileService.kt

@@ -79,17 +79,18 @@ class MyTileService : TileService() {
     myReceiver = PowerConnectionReceiver(this)
     mySettingsHolder = MyTileServiceSettings.Holder(this)
     MyTileServiceSettings.registerWithEventBus(this)
-    handleAutoStartOfService()
+    //handleAutoStartOfService()
     d(TAG, "onCreate: ")
   }
 
-  private fun handleAutoStartOfService() {
-    if (mySettingsHolder.value.autoStartEnabled && isCharging(this)) {
-      commandStart()
-      d(TAG, "MyTileService.handleAutoStartOfService: Initiate auto start")
-    }
-    else d(TAG, "MyTileService.handleAutoStartOfService: Do not auto start")
-  }
+//  private fun handleAutoStartOfService() {
+//    if (mySettingsHolder.value.autoStartEnabled && isCharging(this)) {
+//      showToast(applicationContext, "MyTileService: autoStartEnabled & isCharging -> auto start service")
+//      commandStart()
+//      d(TAG, "MyTileService.handleAutoStartOfService: Initiate auto start")
+//    }
+//    else d(TAG, "MyTileService.handleAutoStartOfService: Do not auto start")
+//  }
 
   override fun onDestroy() {
     super.onDestroy()

app/src/main/java/com/r3bl/stayawake/PowerConnectionReceiver.kt

@@ -65,12 +65,12 @@ class PowerConnectionReceiver(private val myContext: Context) : BroadcastReceive
     if (mySettingsHolder.value.autoStartEnabled) {
       MyTileService.fireIntentWithStartService(myContext)
       val message = "onReceive: PowerConnectionReceiver ACTION_POWER_CONNECTED ... Start Service"
-      // showToast(myContext, message)
+      //showToast(myContext, message)
       d(TAG, message)
     }
     else {
       val message = "onReceive: PowerConnectionReceiver ACTION_POWER_CONNECTED ... Do not auto start"
-      // showToast(myContext, message)
+      //showToast(myContext, message)
       d(TAG, message)
     }
   }
@@ -79,12 +79,12 @@ class PowerConnectionReceiver(private val myContext: Context) : BroadcastReceive
     if (mySettingsHolder.value.autoStartEnabled) {
       MyTileService.fireIntentWithStopService(myContext)
       val message = "onReceive: PowerConnectionReceiver ACTION_POWER_DISCONNECTED ... Stop Service"
-      // showToast(myContext, message)
+      //showToast(myContext, message)
       d(TAG, message)
     }
     else {
       val message = "onReceive: PowerConnectionReceiver ACTION_POWER_DISCONNECTED ... Do not auto start"
-      // showToast(myContext, message)
+      //showToast(myContext, message)
       d(TAG, message)
     }
   }