rabbit_runtime_parameters: Remove dead 'value_global/2', 'value/4' (backport #11614) #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
`rabbit_runtime_parameters:value_global/2` was only used in `rabbit_nodes:cluster_name/0` since near the beginning of the commit history of the server and its usage was eliminated in 06932b9 (#3085, released in v3.8.17+ and v3.9.0+). `rabbit_runtime_parameters:value/4` doesn't appear to have been ever used since it was introduced near the beginning of the commit history. It may have been added just to mirror `value_global/2`'s interface. Eliminating these dead functions allows us to also eliminate a somewhat complicated function `rabbit_db_rtparams:get_or_set/2`. (cherry picked from commit 427876b)
|
Note: this is not a functional change, so can even be included into Tanzu RabbitMQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rabbit_runtime_parameters:value_global/2was only used inrabbit_nodes:cluster_name/0since near the beginning of the commit history of the server and its usage was eliminated in 06932b9 (#3085, released in v3.8.17+ and v3.9.0+).rabbit_runtime_parameters:value/4doesn't appear to have been ever used since it was introduced near the beginning of the commit history. It may have been added just to mirrorvalue_global/2's interface.Eliminating these dead functions allows us to also eliminate a somewhat complicated function
rabbit_db_rtparams:get_or_set/2.This change is ported out of #10915 and was introduced there so we don't need to refactor these functions to handle database errors.
This is an automatic backport of pull request #11614 done by Mergify.