Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-v1] Fix missing rack/session file #27

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

pboling
Copy link

@pboling pboling commented Dec 1, 2023

The stable-v1 README's "Usage" section states:

In your config.ru:

# config.ru

require 'rack/session' # <====== 💣💣💣 LoadError! 💣💣💣 
use Rack::Session::Cookie,
   :domain => 'mywebsite.com',
   :path => '/',
   :expire_after => 3600*24,
   :secret => '**unique secret key**'

Following the readme will break any app you try it in!

This PR fixes v1 so it works the same way as v2.

The alternative to this would be to add a rack/session file in a new legacy release of Rack v2 (it is autoloaded, so it actually doesn't have one, which is why this is an issue in the first place).

@pboling pboling changed the title Fix missing rack/session file [stable-v1] Fix missing rack/session file Dec 1, 2023
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this.

lib/rack/session.rb Outdated Show resolved Hide resolved
@ioquatix ioquatix merged commit bd4f298 into rack:stable-v1 Dec 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants