Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rack classes #10

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Remove unused rack classes #10

merged 1 commit into from
Nov 2, 2024

Conversation

p8
Copy link
Contributor

@p8 p8 commented Aug 25, 2023

These are no longer autoloaded so they can be removed.
See:
rack/rack@fd7e0ad
rack/rack#2113 (comment)

@ioquatix
Copy link
Member

I don't think we can merge this as it will break compatibility. However, I'll check tomorrow.

@dentarg
Copy link

dentarg commented Aug 26, 2023

If merged and released in a new major version of the rackup gem, this could be okay? The Rack upgrade guide does mention classes were renamed. The guide could be amended to mention in which rackup version the old classes was removed.

@ioquatix
Copy link
Member

Yes, that would be totally fine, however my suggestion is, there is no hurry to do this, and the sooner we do it, the more pain we will cause. So, IMHO, let's wait until Rack 3.0 and Rails 7.1 is well and truly out the door, maybe even Rails 8.0 - Rack 2.x will likely be deprecated around that time, then this change will be painless. Unless there is some value in doing it sooner, I'd vote we wait to avoid creating potential pain for users.

@dentarg
Copy link

dentarg commented Aug 26, 2023

Totally agree with that.

@p8
Copy link
Contributor Author

p8 commented Aug 28, 2023

If we are going to keep these for a while, should the autoload logic be copied to rackup instead?
If a new version of Rack is released, the Rack::Server and Rack::Handler no longer get autoloaded.

@ioquatix
Copy link
Member

ioquatix commented Aug 28, 2023

I think that’s reasonable.

@ioquatix ioquatix force-pushed the remove-lib-rack branch 2 times, most recently from 0d1c9e8 to 62e8e82 Compare November 2, 2024 02:50
These are no longer autoloaded so they can be removed.
See:
rack/rack@fd7e0ad
@ioquatix
Copy link
Member

ioquatix commented Nov 2, 2024

I've added both Puma and Falcon to the external test suite, and everything is passing, so I'm good to merge this now. Tangentially related, I'm happy that we gave this time to percolate through the system, so thanks for your patience.

@ioquatix ioquatix merged commit 4e72d9d into rack:main Nov 2, 2024
19 checks passed
@ioquatix
Copy link
Member

ioquatix commented Nov 2, 2024

Released in v2.2.0.

@ioquatix ioquatix self-assigned this Nov 2, 2024
@ioquatix ioquatix added the enhancement New feature or request label Nov 2, 2024
@ioquatix ioquatix added this to the v2.2.0 milestone Nov 2, 2024
@p8 p8 deleted the remove-lib-rack branch November 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants