-
Notifications
You must be signed in to change notification settings - Fork 180
FEATURE FREEZE (Users of this library should read this) #592
Comments
Is this still on track? I see nothing in gophercloud/gophercloud since this issue was created but am holding off on progressing #590. I may just start against this repo and hope the swap is done by the time I'm complete :) |
Still on track |
Will be ready on Monday. I have changes locally that will be pushed upstream to |
Still on track to be done sometime today (Monday). Finishing porting LBaaS v2. |
The bulk of the work for this has been completed, at least to the point where issues can start being created against the new repo. Please be sure to read the updated README, CONTRIBUTING and STYLEGUIDE documents before contributing. Unit tests pass, but I haven't touched acceptance tests, for which I'm working on a way to run periodically. I haven't gotten around to adding anything to the CHANGELOG. Most code written against this repo's API should continue to work in the new one. The exceptions off the top of my head are the most recent PR's that I didn't review (LBaaS v2, Volumes v2). For those, there were some naming and implementation issues that were changed for consistency. If you find something that worked here but doesn't in the new repo, please feel free to submit a PR to the MIGRATING file (which is currently empty). In addition some things are still unstable; error handling, for example. Errors are currently a public API, but that may change soon in favor of an |
As per rackspace/gophercloud#592 the repo rackspace/gophercloud is considered deprecated. It has moved to gophercloud/gophercloud Change-Id: Ib9b608408c3164d2605d7fb6e4a153e07bc7905f Reviewed-on: http://softwarefactory-project.io/r/5042 Reviewed-by: Sylvain Afchain <safchain@gmail.com> Tested-by: Sylvain Afchain <safchain@gmail.com> Workflow: Sylvain Afchain <safchain@gmail.com> Tested-by: Jenkins CI <jenkins@softwarefactory-project.io>
Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Remove cloud provider rackspace **What this PR does / why we need it**: For now, we have to implement functions in both `rackspace` and `openstack` packages if we want to add function for cinder, for example [resize for cinder](#51498). Since openstack has implemented all the functions rackspace has, and rackspace is considered deprecated for a long time, [rackspace deprecated](rackspace/gophercloud#592) , after talking with @mikedanese and @jamiehannaford offline , i sent this PR to remove `rackspace` in favor of `openstack` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52854 **Special notes for your reviewer**: **Release note**: ```release-note The Rackspace cloud provider has been removed after a long deprecation period. It was deprecated because it duplicates a lot of the OpenStack logic and can no longer be maintained. Please use the OpenStack cloud provider instead. ```
Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Remove cloud provider rackspace **What this PR does / why we need it**: For now, we have to implement functions in both `rackspace` and `openstack` packages if we want to add function for cinder, for example [resize for cinder](kubernetes/kubernetes#51498). Since openstack has implemented all the functions rackspace has, and rackspace is considered deprecated for a long time, [rackspace deprecated](rackspace/gophercloud#592) , after talking with @mikedanese and @jamiehannaford offline , i sent this PR to remove `rackspace` in favor of `openstack` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52854 **Special notes for your reviewer**: **Release note**: ```release-note The Rackspace cloud provider has been removed after a long deprecation period. It was deprecated because it duplicates a lot of the OpenStack logic and can no longer be maintained. Please use the OpenStack cloud provider instead. ```
Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Remove cloud provider rackspace **What this PR does / why we need it**: For now, we have to implement functions in both `rackspace` and `openstack` packages if we want to add function for cinder, for example [resize for cinder](kubernetes/kubernetes#51498). Since openstack has implemented all the functions rackspace has, and rackspace is considered deprecated for a long time, [rackspace deprecated](rackspace/gophercloud#592) , after talking with @mikedanese and @jamiehannaford offline , i sent this PR to remove `rackspace` in favor of `openstack` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52854 **Special notes for your reviewer**: **Release note**: ```release-note The Rackspace cloud provider has been removed after a long deprecation period. It was deprecated because it duplicates a lot of the OpenStack logic and can no longer be maintained. Please use the OpenStack cloud provider instead. ```
New features (read: features not currently pending in a PR) will no longer be added to this library. Over the next month (tentatively), the library will be migrated to gophercloud/gophercloud and the
rackspace
directory will be moved to its own, yet-to-be-made-public repository. Bug fixes will be reviewed and merged, and this repo will continue to exist, though (in a month or so) it should be considered deprecated.Pending pull requests in this repository will go through the review process and, if suitable, will ultimately be merged before being migrated to the new one(s). Outstanding issues that do not have pull requests will be addressed in the new repo(s). The new repos were created with the git history of this repo and as such user contributions will, for the most part, be maintained.
Currently the
gophercloud/gophercloud
repo is not accepting pull requests for 2 reasons:When those 2 items are completed, this issue will be updated, and the repos will be open for PRs. Currently, issues may be created in
gophercloud/gophercloud
to discuss changes to the new API and feature requests.The new repo(s) are almost entirely backwards-compatible with this one. Backwards-incompatible changes will be aggregated and enumerated here (in this issue's description).
This issue will exist to provide updates on the migrations (ie. when the APIs are stable, when users can start contributing PRs to the new libraries, ...)
The text was updated successfully, but these errors were encountered: