Pure Ruby s.files using Dir[]
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarber623
changed the title
s.files using Dir.libs.files using Dir[]
This change replaces the `s.files` value, removing the reliance on a system installation of Git. The replacement globs files from `lib` and appends a few other useful files into the built gem. As a bonus, this should trim back a bit on the published gem size (about 30k in a quick local test).
jgarber623
force-pushed
the
pure-ruby-spec-files
branch
from
2195a81 to
84bf373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for considering this change.
This PR replaces the
s.filesvalue inhumanize.gemspec, removing the reliance on a system installation of Git. The replacement globs files fromliband appends a few other useful files into the built gem.As a bonus, this should trim back a bit on the published gem size (about 30k in a quick local test).