Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service startup II #3208

Merged
merged 73 commits into from
Nov 1, 2024
Merged

service startup II #3208

merged 73 commits into from
Nov 1, 2024

Conversation

andre-merzky
Copy link
Member

@andre-merzky andre-merzky commented Jul 5, 2024

This improves agent service startup, and allows to expose service endpoints to tasks.

This closes #2899 and #3062.

@andre-merzky andre-merzky marked this pull request as draft July 12, 2024 22:36
@andre-merzky andre-merzky marked this pull request as ready for review July 15, 2024 12:26
@andre-merzky andre-merzky changed the base branch from devel to feature/service_startup July 15, 2024 12:50
@andre-merzky
Copy link
Member Author

This should be ready for review again.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, all pw logs appeared in the current directory.. (and not in the client sandbox)

src/radical/pilot/task.py Outdated Show resolved Hide resolved
bin/radical-pilot-service-wrapper Outdated Show resolved Hide resolved
bin/radical-pilot-service-wrapper Outdated Show resolved Hide resolved
bin/radical-pilot-service-wrapper Outdated Show resolved Hide resolved
@mtitov mtitov disabled auto-merge November 1, 2024 01:28
Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, but overall PR is ready - test run finished successfully

update: CI tests failed

bin/radical-pilot-service-wrapper Outdated Show resolved Hide resolved
bin/radical-pilot-service-wrapper Show resolved Hide resolved
@andre-merzky
Copy link
Member Author

Thanks for your patience, @mtitov - tasks are fixed now.

@andre-merzky andre-merzky merged commit 72b7487 into devel Nov 1, 2024
31 checks passed
@andre-merzky andre-merzky deleted the feature/service_startup_2 branch November 1, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand service tasks with capability to run on every node
4 participants