Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tianjin-Sugon resource config #3248

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

AymenFJA
Copy link
Contributor

Adding resource config

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.83%. Comparing base (b23c0f4) to head (b9c7f5a).
Report is 7 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3248   +/-   ##
=======================================
  Coverage   42.83%   42.83%           
=======================================
  Files          97       97           
  Lines       11246    11246           
=======================================
  Hits         4817     4817           
  Misses       6429     6429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One question: the description says its a heterogeneous cluster. How is that handled exactly?

@mtitov mtitov linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AymenFJA AymenFJA merged commit 8934069 into devel Nov 6, 2024
31 checks passed
@AymenFJA AymenFJA deleted the feature/tianjin_sugon_cluster branch November 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tianjin Sugon HPC resource config
3 participants