feat: add subintent polling [wip]

radixdlt · Nov 29, 2024 · 45775dd · 45775dd
1 parent 5531222
commit 45775dd
Show file tree

Hide file tree

Showing 17 changed files with 262 additions and 114 deletions.
diff --git a/packages/common/src/index.ts b/packages/common/src/index.ts
@@ -28,18 +28,20 @@ export type RadixButtonMode = keyof typeof RadixButtonMode
 export type PersonaData = { field: string; value: string }
 
 export const RequestStatus = {
+  fail: 'fail',
+  lookup: 'lookup',
+  ignored: 'ignored',
   pending: 'pending',
   success: 'success',
-  fail: 'fail',
+  timedOut: 'timedOut',
   cancelled: 'cancelled',
-  ignored: 'ignored',
 } as const
 
 export const RequestItemType = {
-  loginRequest: 'loginRequest',
   dataRequest: 'dataRequest',
-  sendTransaction: 'sendTransaction',
   proofRequest: 'proofRequest',
+  loginRequest: 'loginRequest',
+  sendTransaction: 'sendTransaction',
   preAuthorizationRequest: 'preAuthorizationRequest',
 } as const
 
@@ -49,6 +51,10 @@ export type RequestItemTypes = keyof typeof RequestItemType
 
 export type RequestStatusTypes = keyof typeof RequestStatus
 
+/**
+ * Not used in the codebase. Will be removed in the next major release future.
+ * @deprecated
+ */
 export type WalletRequest<
   RequestType extends RequestItemTypes,
   Status extends RequestStatusTypes,
@@ -81,3 +87,4 @@ export type RequestItem = {
   metadata?: Record<string, string | number | boolean>
   walletData?: any
 }
+
diff --git a/packages/connect-button/src/components/card/card.stories.ts b/packages/connect-button/src/components/card/card.stories.ts
@@ -97,7 +97,7 @@ export const Requests: Story = {
           console.log('onIgnoreTransactionItem', event)
         }}
         ?showCancel="${args.showCancel}"
-        transactionIntentHash="${args.transactionIntentHash}"
+        hash="${args.transactionIntentHash}"
       ></radix-request-card>
     </radix-popover>
   `,

diff --git a/packages/connect-button/src/components/card/request-card.ts b/packages/connect-button/src/components/card/request-card.ts
@@ -45,7 +45,7 @@ export class RadixRequestCard extends LitElement {
   @property({
     type: String,
   })
-  transactionIntentHash: string = ''
+  hash: string = ''
 
   render() {
     const icon = this.getIconFromStatus()
@@ -57,8 +57,10 @@ export class RadixRequestCard extends LitElement {
         cancelled: 'Transaction Cancelled',
         ignored: 'Transaction Ignored',
         success: 'Send transaction',
+        lookup: '',
+        timedOut: '',
         content: html`
-          ${this.renderTxIntentHash()}
+          ${this.renderHash()}
           ${this.status === 'pending'
             ? html`<div class="request-content">
                 Open your Radix Wallet app to review the transaction
@@ -73,11 +75,41 @@ export class RadixRequestCard extends LitElement {
             : ''}
         `,
       },
+      preAuthorizationRequest: {
+        pending: 'Preauthorization Pending',
+        fail: 'Preauthorization Failed',
+        cancelled: 'Preauthorization Cancelled',
+        success: 'Preauthorization Request',
+        ignored: 'Preauthorization Ignored',
+        lookup: 'Preauthorization Lookup',
+        timedOut: 'Preauthorization Timed Out',
+        content: html`
+          ${this.renderHash()}
+          ${this.status === 'pending'
+            ? html`<div class="request-content">
+                Open your Radix Wallet app to review the preauthorization
+                ${this.showCancel
+                  ? html`<div class="cancel" @click=${this.onCancel}>
+                      Cancel
+                    </div>`
+                  : html`<div class="cancel" @click=${this.onIgnore}>
+                      Ignore
+                    </div>`}
+              </div>`
+            : this.status === 'lookup'
+              ? html`<div class="request-content">
+                  <div class="cancel" @click=${this.onIgnore}>Ignore</div>
+                </div>`
+              : ''}
+        `,
+      },
       dataRequest: {
         pending: 'Data Request Pending',
         fail: 'Data Request Rejected',
         cancelled: 'Data Request Rejected',
         ignored: '',
+        lookup: '',
+        timedOut: '',
         success: 'Data Request',
         content: this.getRequestContentTemplate(
           'Open Your Radix Wallet App to complete the request',
@@ -89,6 +121,8 @@ export class RadixRequestCard extends LitElement {
         cancelled: 'Login Request Rejected',
         success: 'Login Request',
         ignored: '',
+        lookup: '',
+        timedOut: '',
         content: this.getRequestContentTemplate(
           'Open Your Radix Wallet App to complete the request',
         ),
@@ -99,16 +133,8 @@ export class RadixRequestCard extends LitElement {
         cancelled: 'Proof Request Rejected',
         success: 'Proof Request',
         ignored: '',
-        content: this.getRequestContentTemplate(
-          'Open Your Radix Wallet App to complete the request',
-        ),
-      },
-      preAuthorizationRequest: {
-        pending: 'Preauthorization Request Pending',
-        fail: 'Preauthorization Request Rejected',
-        cancelled: 'Preauthorization Request Rejected',
-        success: 'Preauthorization Request',
-        ignored: '',
+        lookup: '',
+        timedOut: '',
         content: this.getRequestContentTemplate(
           'Open Your Radix Wallet App to complete the request',
         ),
@@ -136,7 +162,7 @@ export class RadixRequestCard extends LitElement {
       : ''
   }
 
-  private isErrorStatus(status: RequestStatusTypes) {
+  private hasErrorIcon(status: RequestStatusTypes) {
     return (
       [
         RequestStatus.cancelled,
@@ -146,19 +172,31 @@ export class RadixRequestCard extends LitElement {
     ).includes(status)
   }
 
+  private hasPendingIcon(status: RequestStatusTypes) {
+    return ([RequestStatus.pending, RequestStatus.lookup] as string[]).includes(
+      status,
+    )
+  }
+
+  private hasIgnoredIcon(status: RequestStatusTypes) {
+    return (
+      [RequestStatus.ignored, RequestStatus.timedOut] as string[]
+    ).includes(status)
+  }
+
   private getIconFromStatus() {
-    return this.status === RequestStatus.pending
+    return this.hasPendingIcon(this.status)
       ? 'pending'
-      : this.status === RequestStatus.ignored
+      : this.hasIgnoredIcon(this.status)
         ? 'ignored'
-        : this.isErrorStatus(this.status)
+        : this.hasErrorIcon(this.status)
           ? 'error'
           : 'checked'
   }
 
   private getStylingFromStatus() {
     return classMap({
-      dimmed: this.isErrorStatus(this.status),
+      dimmed: this.hasErrorIcon(this.status),
       inverted: this.status === 'pending',
     })
   }
@@ -189,21 +227,24 @@ export class RadixRequestCard extends LitElement {
     )
   }
 
-  private renderTxIntentHash() {
-    return this.transactionIntentHash
+  private renderHash() {
+    return this.hash
       ? html`<div class="transaction">
           <span class="text-dimmed">ID:</span>
           <radix-link
-            displayText="${shortenAddress(this.transactionIntentHash)}"
+            displayText="${shortenAddress(this.hash)}"
             @click=${(event: MouseEvent) => {
               event.preventDefault()
               this.dispatchEvent(
                 new CustomEvent('onLinkClick', {
                   bubbles: true,
                   composed: true,
                   detail: {
-                    type: 'transaction',
-                    data: this.transactionIntentHash,
+                    type:
+                      this.type === 'sendTransaction'
+                        ? 'transaction'
+                        : 'subintent',
+                    data: this.hash,
                   },
                 }),
               )

diff --git a/packages/connect-button/src/components/pages/requests.ts b/packages/connect-button/src/components/pages/requests.ts
@@ -36,7 +36,7 @@ export class RadixRequestsPage extends LitElement {
               type="${requestItem.type}"
               status="${requestItem.status}"
               id="${requestItem.interactionId}"
-              transactionIntentHash="${requestItem.transactionIntentHash || ''}"
+              hash="${requestItem.transactionIntentHash || ''}"
               ?showCancel="${requestItem.showCancel}"
               timestamp=${requestItem.createdAt}
             ></radix-request-card>`,

diff --git a/packages/dapp-toolkit/src/_types.ts b/packages/dapp-toolkit/src/_types.ts
@@ -37,6 +37,7 @@ export type Providers = {
 export type ExplorerConfig = {
   baseUrl: string
   transactionPath: string
+  subintentPath: string
   accountsPath: string
 }
 

diff --git a/packages/dapp-toolkit/src/helpers/exponential-backoff.ts b/packages/dapp-toolkit/src/helpers/exponential-backoff.ts
@@ -6,7 +6,7 @@ import { map, merge, of, Subject, switchMap, timer } from 'rxjs'
 export type ExponentialBackoffInput = {
   multiplier?: number
   maxDelayTime?: number
-  timeout?: number
+  timeout?: number | Date
   interval?: number
 }
 export type ExponentialBackoff = typeof ExponentialBackoff
@@ -17,6 +17,7 @@ export const ExponentialBackoff = ({
   interval = 2_000,
 }: ExponentialBackoffInput = {}) => {
   const trigger = new Subject<void>()
+  const stop = new Subject<void>()
   let numberOfRetries = 0
 
   const backoff$ = merge(
@@ -36,12 +37,19 @@ export const ExponentialBackoff = ({
   )
 
   const withBackoffAndTimeout$: Observable<Result<number, { error: string }>> =
-    timeout
-      ? merge(
-          backoff$,
-          timer(timeout).pipe(map(() => err({ error: 'timeout' }))),
-        )
-      : backoff$
+    merge(
+      stop.asObservable().pipe(map(() => err({ error: 'stopped' }))),
+      timeout
+        ? merge(
+            backoff$,
+            timer(timeout).pipe(map(() => err({ error: 'timeout' }))),
+          )
+        : backoff$,
+    )
 
-  return { trigger, withBackoff$: withBackoffAndTimeout$ }
+  return {
+    trigger,
+    withBackoff$: withBackoffAndTimeout$,
+    stop: () => stop.next(),
+  }
 }
diff --git a/packages/dapp-toolkit/src/modules/connect-button/connect-button.module.ts b/packages/dapp-toolkit/src/modules/connect-button/connect-button.module.ts
@@ -66,11 +66,13 @@ export const ConnectButtonModule = (
   const logger = input?.logger?.getSubLogger({ name: 'ConnectButtonModule' })
   const subjects = input.subjects || ConnectButtonSubjects()
   const dAppDefinitionAddress = input.dAppDefinitionAddress
-  const { baseUrl, accountsPath, transactionPath } = input.explorer ?? {
-    baseUrl: RadixNetworkConfigById[input.networkId].dashboardUrl,
-    transactionPath: '/transaction/',
-    accountsPath: '/account/',
-  }
+  const { baseUrl, accountsPath, transactionPath, subintentPath } =
+    input.explorer ?? {
+      baseUrl: RadixNetworkConfigById[input.networkId].dashboardUrl,
+      transactionPath: '/transaction/',
+      subintentPath: '/subintent/',
+      accountsPath: '/account/',
+    }
   const statusStorage = input.providers.storageModule
 
   const stateModule = input.providers.stateModule
@@ -287,11 +289,15 @@ export const ConnectButtonModule = (
     subjects.onLinkClick
       .pipe(
         tap(({ type, data }) => {
-          if (['account', 'transaction'].includes(type)) {
+          if (['account', 'transaction', 'subintent'].includes(type)) {
             if (!baseUrl || !window) return
 
             const url = `${baseUrl}${
-              type === 'transaction' ? transactionPath : accountsPath
+              type === 'transaction'
+                ? transactionPath
+                : type === 'subintent'
+                  ? subintentPath
+                  : accountsPath
             }${data}`
 
             window.open(url)

diff --git a/packages/dapp-toolkit/src/modules/connect-button/subjects.ts b/packages/dapp-toolkit/src/modules/connect-button/subjects.ts
@@ -31,7 +31,7 @@ export const ConnectButtonSubjects = () => ({
   personaData: new BehaviorSubject<{ value: string; field: string }[]>([]),
   dAppName: new BehaviorSubject<string>(''),
   onLinkClick: new Subject<{
-    type: 'account' | 'transaction' | 'setupGuide' | 'showQrCode' | 'getWallet'
+    type: 'account' | 'transaction' | 'setupGuide' | 'showQrCode' | 'getWallet' | 'subintent'
     data: string
   }>(),
 })
diff --git a/packages/dapp-toolkit/src/modules/connect-button/types.ts b/packages/dapp-toolkit/src/modules/connect-button/types.ts
@@ -23,7 +23,7 @@ export type ConnectButtonModuleOutput = {
   onShowPopover$: Observable<void>
   onCancelRequestItem$: Observable<string>
   onLinkClick$: Observable<{
-    type: 'account' | 'transaction' | 'showQrCode' | 'setupGuide' | 'getWallet'
+    type: 'account' | 'transaction' | 'showQrCode' | 'setupGuide' | 'getWallet' | 'subintent'
     data: string
   }>
   setMode: (value: 'light' | 'dark') => void