fix: error interactions regression #293
Conversation
failed interactions were never resolved in connect button
dawidsowardx
force-pushed
the
fix-error-wallet-response-regression
branch
from
26208f5 to
4254878
Compare
| ), | ||
| ) | ||
| ) | ||
| .mapErr((error) => logger?.error({ method: 'addWalletResponses', error })) |
There was a problem hiding this comment.
returns the logger object ILogObjMeta
There was a problem hiding this comment.
Yeah saw that decided to not change as it's not a problem, this error is not consumed anywhere after that. I can make it return undefined
There was a problem hiding this comment.
Or map to SdkError just for the sake of consistency?
There was a problem hiding this comment.
It's not consumed. Does not really matter
| ): ResultAsync<unknown, SdkError> => | ||
| ): ResultAsync< | ||
| WalletInteractionSuccessResponse, | ||
| SdkError | WalletInteractionFailureResponse |
There was a problem hiding this comment.
can we keep it as SdkError only?
There was a problem hiding this comment.
No because it'd not be adequate. It can error with FailureResponse that's actually the whole point of this regression :)
| isSupported: () => _isSupported, | ||
| destroy: () => {}, | ||
| disconnect: () => {}, | ||
| send: () => { |
There was a problem hiding this comment.
why not use vitest fn for this purpose?
|
🎉 This PR is included in version 2.2.0-dev.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
failed interactions were never resolved in connect button