Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around onDidCloseTextDocument firing on a wrong document. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mprobst
Copy link

@mprobst mprobst commented Oct 6, 2017

Sometimes onDidCloseTextDocument seems to get called with a different
document (something involving git?). This works around the problem by
also watching the list of visible editors, and closing the session.

Works around issue #26, related to upstream issue
microsoft/vscode#30820.

Sometimes onDidCloseTextDocument seems to get called with a different
document (something involving git?). This works around the problem by
also watching the list of visible editors, and closing the session.

Works around issue rafaelmaiolla#26, related to upstream issue
microsoft/vscode#30820.
@sepich
Copy link

sepich commented Mar 10, 2019

Unfortunately this only works for case one tab has been opened and then closed.
visibleTextEditors[] are not all opened tabs, but only visible (usually just current one)
microsoft/vscode#15178
So, any actions with tabs closes Session for first opened file.
For example try:

  • rmate -w file
  • Doubleclick tab-bar to open new blank tab
  • See that Session is already stopped, while first file is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants