add fish snippets from bmalehorn/vscode-fish #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkelleyDevelopment
requested changes
Dec 2, 2024
| "end" | ||
| ] | ||
| }, | ||
| "else operator": { |
There was a problem hiding this comment.
The else snippet can probably be omitted since the if and if else are already defined here
| "end" | ||
| ] | ||
| }, | ||
| "function with arguments definition": { |
There was a problem hiding this comment.
these snippets should also be removed in favor of just having someone leverage the first function snippet.
There was a problem hiding this comment.
Please take this comment to apply to the if and while snippet variants too.
There was a problem hiding this comment.
Note sure what you mean here (not very familiar with snippet development). How to leverage the multiple possibility with only one snippet ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add fish snippets from bmalehorn/vscode-fish
Thanks form maintaining this repo !