Grade exams manually #1253
Merged
Grade exams manually #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 26, 2024 16:06
nygrenh
requested changes
Jun 13, 2024
| .await?; | ||
|
|
||
| let mut list: Vec<ExerciseSlideSubmissionAndUserExerciseState> = Vec::new(); | ||
| for sub in submissions { |
There was a problem hiding this comment.
This needs to be done without the loop to prevent the n+1 problem
| FROM exercise_slide_submissions | ||
| WHERE exercise_id = $1 | ||
| AND deleted_at IS NULL | ||
| AND created_at in (SELECT MAX(created_at) FROM exercise_slide_submissions GROUP BY user_id, exercise_slide_id) |
There was a problem hiding this comment.
Matches all records that have the same created at.
Mayb you can use the SQL HAVING keyword here?
| Ok(count.count.unwrap_or(0).try_into()?) | ||
| } | ||
|
|
||
| pub async fn exercise_slide_submissions_and_user_exercise_state_list_with_exercise_id( |
There was a problem hiding this comment.
method name should say that it gets the latest submission per user
| Vec::new(); | ||
|
|
||
| // Check if student has any published grading results they can view at the exam page | ||
| for grading_decision in teachers_grading_decisions_list.into_iter() { |
|
|
||
| let exercises = models::exercises::get_exercises_by_exam_id(&mut conn, *exam_id).await?; | ||
|
|
||
| for exercise in exercises.iter() { |
|
|
||
| let exercise_slide_submissions_and_user_exercise_state_list = payload.0; | ||
|
|
||
| for submission in exercise_slide_submissions_and_user_exercise_state_list.into_iter() { |
There was a problem hiding this comment.
Fixing this n+1 is not worth the effort
| .getByRole("button") | ||
| .click() | ||
| await teacherPage.locator("#Justification").fill("Ok") | ||
| await teacherPage.getByRole("textbox", { name: "undefinedfalse" }).fill("1") |
| teacherPage.getByRole("row", { name: "Grade Question 1 Graded 2 2 2" }), | ||
| ).toBeVisible() | ||
| await expect(teacherPage.getByText("You have 2 unpublished grading results")).toBeVisible() | ||
|
|
There was a problem hiding this comment.
Before publishing, verify that the students cannot see the results yet
| const globalX = pivotPointRect.x - rect.width / 2 + pivotPointRect.width / 2 | ||
| const globalY = pivotPointRect.y - rect.height + 10 | ||
|
|
||
| /* |
nygrenh
requested changes
Jun 13, 2024
| onClick={() => { | ||
| const confirmation = confirm( | ||
| // eslint-disable-next-line i18next/no-literal-string | ||
| `Do you want to publish all currently graded submissions?`, |
There was a problem hiding this comment.
This string should be translated
Maijjay
force-pushed
the
grade-exams-manually
branch
from
bdd756c
to
cbeb17f
Compare
nygrenh
reviewed
Jul 9, 2024
| AND user_id = $2 | ||
| AND deleted_at IS NULL | ||
| ", | ||
| exam_id, |
There was a problem hiding this comment.
WHERE exam_id = $1 AND user_id IN UNNEST....
Maijjay
force-pushed
the
grade-exams-manually
branch
from
bd28a03
to
75c0cac
Compare
# Conflicts: # services/course-material/src/services/backend.ts # shared-module/packages/common/src/locales/en/course-material.json
github-actions
bot
added
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.