feat(phpcs): Enforce fully multiline arguments

ragusa87 · Dec 7, 2024 · 6d68345 · 6d68345
1 parent a172362
commit 6d68345
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 11 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -26,6 +26,9 @@
     'visibility_required' => [
         'elements' => ['property', 'method', 'const'],
     ],
+    'method_argument_space' => [
+        'on_multiline' => 'ensure_fully_multiline',
+    ],
     'yoda_style' => false,
 ]);
 

diff --git a/src/Controller/Kobo/Api/ImageController.php b/src/Controller/Kobo/Api/ImageController.php
@@ -32,8 +32,8 @@ public function __construct(
         protected ShelfRepository $shelfRepository,
         protected LoggerInterface $logger,
         protected DownloadHelper $downloadHelper,
-        protected SyncResponseFactory $syncResponseFactory)
-    {
+        protected SyncResponseFactory $syncResponseFactory,
+    ) {
     }
 
     /**

diff --git a/src/Kobo/Proxy/KoboProxyLoggerFactory.php b/src/Kobo/Proxy/KoboProxyLoggerFactory.php
@@ -10,8 +10,8 @@ class KoboProxyLoggerFactory
 {
     public function __construct(
         protected KoboProxyConfiguration $configuration,
-        protected LoggerInterface $koboProxyLogger)
-    {
+        protected LoggerInterface $koboProxyLogger,
+    ) {
     }
 
     public function create(string $accessToken): KoboProxyLogger

diff --git a/src/Kobo/Proxy/KoboStoreProxy.php b/src/Kobo/Proxy/KoboStoreProxy.php
@@ -97,11 +97,13 @@ private function _proxy(Request $request, string $hostname, array $config = []):
 
         $client = $this->getClient($request);
 
-        $psrResponse = $client->send($psrRequest, [
-            'base_uri' => $hostname,
-            'http_errors' => false,
-            'connect_timeout' => 5,
-        ] + $config
+        $psrResponse = $client->send(
+            $psrRequest,
+            [
+                'base_uri' => $hostname,
+                'http_errors' => false,
+                'connect_timeout' => 5,
+            ] + $config
         );
 
         return $this->convertResponse($psrResponse, $config['stream'] ?? true);

diff --git a/tests/Controller/Kobo/Api/V1/DownloadControllerTest.php b/tests/Controller/Kobo/Api/V1/DownloadControllerTest.php
@@ -43,8 +43,10 @@ public function testDownloadMissingBook(): void
 
         $client = self::getClient();
 
-        $client?->request('GET',
-            sprintf('/kobo/%s/v1/download/%s.%s', KoboFixture::ACCESS_KEY, $book->getId(), MetadataResponseService::KEPUB_FORMAT));
+        $client?->request(
+            'GET',
+            sprintf('/kobo/%s/v1/download/%s.%s', KoboFixture::ACCESS_KEY, $book->getId(), MetadataResponseService::KEPUB_FORMAT)
+        );
         self::assertResponseStatusCodeSame(403);
     }